Re: [Patch -v3 3/4] checkpatch.pl the new kernel/reboot.c file.

[Joe Perches]

(trimmed cc's)

On Tue, 2013-04-16 at 04:41 -0500, Robin Holt wrote:
> On Mon, Apr 15, 2013 at 10:45:38AM -0700, Joe Perches wrote:
> > trivia:
> > I'd make these changes on top of your patch:
> > o Additional OOM messages aren't necessary as a dump_stack is done
> I am not sure what I should be doing with this one.

It could be removed eventually.

> The only message
> that seems close is the pr_warn("%s failed to allocate memory for...
> but I don't see how dump_stack is getting invoked so I think either
> you did not mean this message or you intended me to replace that with a
> dump_stack, in which case, the error message would still be informative
> and the dump_stack would be relatively useless.

All failed mallocs without __GFP_NOWARN get a dump_stack via
mm/page_alloc:warn_alloc_failed() so that pr_warn isn't really
required.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/