Re: [PATCHv3, RFC 09/34] thp: represent file thp pages in meminfoand friends

[Dave Hansen]

On 04/16/2013 07:49 AM, Kirill A. Shutemov wrote:
> Dave Hansen wrote:
>> On 04/05/2013 04:59 AM, Kirill A. Shutemov wrote:
>>> The patch adds new zone stat to count file transparent huge pages and
>>> adjust related places.
>>>
>>> For now we don't count mapped or dirty file thp pages separately.
>>
>> I can understand tracking NR_FILE_TRANSPARENT_HUGEPAGES itself.  But,
>> why not also account for them in NR_FILE_PAGES?  That way, you don't
>> have to special-case each of the cases below:
> 
> Good point.
> To be consistent I'll also convert NR_ANON_TRANSPARENT_HUGEPAGES to be
> accounted in NR_ANON_PAGES.

Hmm...  I didn't realize we did that for the anonymous version.  But,
looking at the meminfo code:

> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>                 K(global_page_state(NR_ANON_PAGES)
>                   + global_page_state(NR_ANON_TRANSPARENT_HUGEPAGES) *
>                   HPAGE_PMD_NR),
> #else
>                 K(global_page_state(NR_ANON_PAGES)),
> #endif

That #ifdef and a couple others like it would just go away if we did
this.  It would be a nice cleanup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/