Re: [PATCH 6/8] spare/sysrq: fix inconstistent help message of sysrqkey

From: zhangwei(Jovi)
Date: Sat Apr 20 2013 - 03:42:15 EST


On 2013/3/8 5:27, David Miller wrote:
> From: "zhangwei(Jovi)" <jovi.zhangwei@xxxxxxxxxx>
> Date: Thu, 7 Mar 2013 17:00:32 +0800
>
>> Currently help message of /proc/sysrq-trigger highlight its
>> upper-case characters, like below:
>>
>> SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
>> memory-full-oom-kill(F) kill-all-tasks(I) ...
>>
>> this would confuse user trigger sysrq by upper-case character, which is
>> inconsistent with the real lower-case character registed key.
>>
>> This inconsistent help message will also lead more confused when
>> 26 upper-case letters put into use in future.
>>
>> This patch fix spare sysrq key: "global-regs(y)"
>>
>> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@xxxxxxxxxx>
>
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
>
David, this patch is already got your ack,
so would you please pick up this patch into your tree for next 3.10?
Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/