Re: [PATCH 6/8] spare/sysrq: fix inconstistent help message ofsysrq key

From: David Miller
Date: Sat Apr 20 2013 - 15:49:31 EST


From: "zhangwei(Jovi)" <jovi.zhangwei@xxxxxxxxxx>
Date: Sat, 20 Apr 2013 15:41:03 +0800

> On 2013/3/8 5:27, David Miller wrote:
>> From: "zhangwei(Jovi)" <jovi.zhangwei@xxxxxxxxxx>
>> Date: Thu, 7 Mar 2013 17:00:32 +0800
>>
>>> Currently help message of /proc/sysrq-trigger highlight its
>>> upper-case characters, like below:
>>>
>>> SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
>>> memory-full-oom-kill(F) kill-all-tasks(I) ...
>>>
>>> this would confuse user trigger sysrq by upper-case character, which is
>>> inconsistent with the real lower-case character registed key.
>>>
>>> This inconsistent help message will also lead more confused when
>>> 26 upper-case letters put into use in future.
>>>
>>> This patch fix spare sysrq key: "global-regs(y)"
>>>
>>> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@xxxxxxxxxx>
>>
>> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
>>
> David, this patch is already got your ack,
> so would you please pick up this patch into your tree for next 3.10?

Sparc patches should be sent to sparclinux@xxxxxxxxxxxxxxx so that they
are properly queued up and tracked in patchwork.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/