RE: [PATCH 1/3] rapidio: make enumeration/discovery configurable

[Bounine, Alexandre]

On Fri, 26 Apr 2013 6:53 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> Subject: Re: [PATCH 1/3] rapidio: make enumeration/discovery
> configurable
> 
> This Kconfig change makes my kbuild do Weird Things.
> 
> make mrproper ; yes "" | make allmodconfig ; make 2>/tmp/x
... skip ... 
> :   DMA Engine support for RapidIO (RAPIDIO_DMA_ENGINE) [Y/n/?] y
> :   RapidIO subsystem debug messages (RAPIDIO_DEBUG) [Y/n/?] y
> :   Enumeration method [M/y/?] (NEW) aborted!
> :
> : Console input/output is redirected. Run 'make oldconfig' to update configuration.
> :
> :   SYSHDR  arch/x86/syscalls/../include/generated/uapi/asm/unistd_32.h
> :   SYSHDR  arch/x86/syscalls/../include/generated/uapi/asm/unistd_64.h
> :   SYSHDR
> arch/x86/syscalls/../include/generated/uapi/asm/unistd_x32.h
> 
> 
> See the "Enumeration method [M/y/?] (NEW) aborted!"
> 
> Note that this only happens when make's stderr is redirected.
> 
> I've no idea what's going on here.  This appears to fix things:
> 
> --- a/drivers/rapidio/Kconfig~rapidio-make-enumeration-discovery-
> configurable-fix
> +++ a/drivers/rapidio/Kconfig
> @@ -59,7 +59,7 @@ choice
>  	  If unsure, select Basic built-in.
> 
>  config RAPIDIO_ENUM_BASIC
> -	tristate "Basic"
> +	bool "Basic"
>  	help
>  	  This option includes basic RapidIO fabric enumeration and
> discovery
>  	  mechanism similar to one described in RapidIO specification
> Annex 1.
> 
> but doesn't appear to be what you intended.

Goal is to build enumerator as a module or built-in.
I will retest v2 of patches for this issue.
There are some changes to Kconfig (removed AUTO_ENUM option).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/