Re: [PATCH v2 2/3] ASoC: spdif_transmitter: Add DT support.

From: Marek Belisko
Date: Mon Apr 29 2013 - 08:17:49 EST

Dear Sebastian Hesselbarth,

On 04/26/2013 09:24 PM, Sebastian Hesselbarth wrote:
On 04/25/2013 03:13 PM, Marek Belisko wrote:
Add devicetree support for this dummy audio soc driver.

Signed-off-by: Michal Bachraty<michal.bachraty@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Marek Belisko<marek.belisko@xxxxxxxxxxxxxxxxxxx>
.../bindings/sound/spdif-transmitter.txt | 10 ++++++++++
sound/soc/codecs/spdif_transmitter.c | 10 ++++++++++
2 files changed, 20 insertions(+)
create mode 100644

diff --git
new file mode 100644
index 0000000..55a8584
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
@@ -0,0 +1,10 @@
+Device-Tree bindings for dummy spdif transmitter
+Required properties:
+ - compatible: should be "linux,spdif-dit".


I remember Daniel commenting on the name already, but
what about "spdif-transmitter" and "spdif-receiver" respectively?
That is very generic and should allow to remove "linux," prefix.
Not sure if linux, prefix can be removed. I believe (at least what documentation said) is that <manufacturer>,<model> must be format for compatible.
And there is a lot of drivers using more informative compatible
strings compared to the driver name.



Marek Belisko

Software Developer
StreamUnlimited Engineering GmbH
Gutheil Schodergasse 8-12
A-1100 Vienna, Austria

Office: +421 267200087

e-mail: marek.belisko@xxxxxxxxxxxxxxxxxxx

Meet us at:

High End - Munich, 09 - 12 May, Hall 4/F05
IFA - Berlin, 6-11 September
CEDIA - Denver, 25-28 September
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at