Re: [Intel-gfx] [PATCH] [TRIVIAL] Fix declaration ofintel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.

[Daniel Vetter]

On Fri, May 03, 2013 at 03:03:37PM +0300, Jani Nikula wrote:
> On Fri, 03 May 2013, Daniel Vetter <daniel@xxxxxxxx> wrote:
> > On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf@xxxxxx wrote:
> >> From: Jan-Simon MÃller <dl9pf@xxxxxx>
> >> 
> >> Description:
> >> intel_gmbus_is_forced_bit is no extern as its body is right below.
> >> Likewise for intel_gmbus_is_port_valid.
> >> 
> >> This fixes a compilation issue with clang. An initial version of this patch
> >> was developed by PaX Team <pageexec at freemail.hu>.
> >> This is respin of this patch.
> >> 
> >> Signed-off-by: Jan-Simon MÃller <dl9pf@xxxxxx>
> >> CC: pageexec@xxxxxxxxxxx
> >> CC: daniel.vetter@xxxxxxxx
> >> CC: airlied@xxxxxxxx
> >> CC: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> >> CC: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> >> CC: linux-kernel@xxxxxxxxxxxxxxx
> > Picked up for -fixes, thanks for the patch.
> 
> Please drop it.
> 
> The patch removes the inline keyword, creating dozens of copies of the
> functions, and consequently loads of warnings:
> 
> drivers/gpu/drm/i915/i915_drv.h:1803:13: warning: âintel_gmbus_is_port_validâ defined but not used [-Wunused-function]
> drivers/gpu/drm/i915/i915_drv.h:1812:13: warning: âintel_gmbus_is_forced_bitâ defined but not used [-Wunused-function]

Meh, rather embarrassing patch reading fail here. Dropped.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/