Re: [Intel-gfx] [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.

From: PaX Team
Date: Sat May 04 2013 - 04:57:01 EST


On 3 May 2013 at 15:03, Jani Nikula wrote:

> >> This fixes a compilation issue with clang. An initial version of this patch
> >> was developed by PaX Team <pageexec at freemail.hu>.
> >> This is respin of this patch.
> >>
> >> Signed-off-by: Jan-Simon MÃller <dl9pf@xxxxxx>
> >> CC: pageexec@xxxxxxxxxxx
> >> CC: daniel.vetter@xxxxxxxx
> >> CC: airlied@xxxxxxxx
> >> CC: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> >> CC: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> >> CC: linux-kernel@xxxxxxxxxxxxxxx
> > Picked up for -fixes, thanks for the patch.
>
> Please drop it.
>
> The patch removes the inline keyword, creating dozens of copies of the
> functions, and consequently loads of warnings:

in my original patch they were both static inline, not sure where the
inline got lost...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/