Re: [PATCH v5 3/7] sched: set initial value of runnable avg for newforked task

From: Alex Shi
Date: Tue May 07 2013 - 01:03:58 EST


On 05/07/2013 11:24 AM, Alex Shi wrote:
>> > The reason to store a small initial "observation" here is so that as
>> > when we reach our next period edge our load converges (presumably
>> > down) towards its true target more smoothly; as well as providing a
>> > task additional protection from being considered "small" through
>> > start-up.
>> >
> It will give new forked task 1 ms extra running time. That will bring
> incorrect info if the new forked goes to sleep a while.
> But this info should benefit to some benchmarks like aim7,
> pthread_cond_broadcast. So I am convinced. :)
>
> What's your opinion of this, Peter?


Here is the patch according to Paul's opinions.
just refer the __update_task_entity_contrib in sched.h looks ugly.
comments are appreciated!

---