Re: [PATCH v5 1/7] Revert "sched: Introduce temporary FAIR_GROUP_SCHEDdependency for load-tracking"

[Alex Shi]

On 05/06/2013 04:55 PM, Paul Turner wrote:
> On Mon, May 6, 2013 at 1:49 AM, Alex Shi <alex.shi@xxxxxxxxx> wrote:
>> On 05/06/2013 04:24 PM, Paul Turner wrote:
>>>>>         /*
>>>>>          * CFS Load tracking
>>>>>          * Under CFS, load is tracked on a per-entity basis and aggregated up.
>>>>> @@ -242,8 +236,7 @@ struct cfs_rq {
>>>>>         u64 runnable_load_avg, blocked_load_avg;
>>>>>         atomic64_t decay_counter, removed_load;
>>>>>         u64 last_decay;
>>>>> -#endif /* CONFIG_FAIR_GROUP_SCHED */
>>>>> -/* These always depend on CONFIG_FAIR_GROUP_SCHED */
>>> We should perhaps replace this with a comment that these are only
>>> needed to aggregate the point-wise representation in the
>>> FAIR_GROUP_SCHED case.
>>>
>>
>> Is the comments ok? :)
>>
>> /* runnable related variables only used in FAIR_GROUP_SCHED */
> 
> Perhaps:
> 
>  -/* These always depend on CONFIG_FAIR_GROUP_SCHED */
> #ifdef ...
> +/* Required to track per-cpu representation of a task_group */

here is the changed patch. 
Do you mind to give a ack or review by? :)

---