Re: [PATCH] x86: make stat/statfs 64-bit for x86_64 kernels

From: Mike Frysinger
Date: Thu May 09 2013 - 00:10:44 EST


On Thursday 09 May 2013 00:04:28 H. Peter Anvin wrote:
> On 05/08/2013 09:00 PM, Mike Frysinger wrote:
> > --- a/arch/x86/include/uapi/asm/statfs.h
> > +++ b/arch/x86/include/uapi/asm/statfs.h
> > +/* For x86-64, both the 64bit and x32 ABIs have 64bit fields. */
> > +#ifdef __x86_64__
> > +#define __statfs_word __u64
> > +#endif
> > +
> >
> > #include <asm-generic/statfs.h>
> > #endif /* _ASM_X86_STATFS_H */
>
> ... or is this what you meant to use?

i didn't intend to use this for stat. that macro is a hook the common asm-
generic/statfs.h header provides for arches.

although maybe the better fix for statfs.h is to do:
--- a/include/uapi/asm-generic/statfs.h
+++ b/include/uapi/asm-generic/statfs.h
@@ -13,7 +13,7 @@
*/
#ifndef __statfs_word
#if __BITS_PER_LONG == 64
-#define __statfs_word long
+#define __statfs_word __u64
#else
#define __statfs_word __u32
#endif
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.