RE: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data toam335x-evm
From: Gupta, Pekon
Date: Thu May 09 2013 - 00:13:10 EST
> > >
> > > am33xx_pinmux: pinmux@44e10800 {
> > > pinctrl-names = "default";
> > > - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>;
> > > + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0
> > > + &nandflash_pins_s0>;
> >
> > Why add this to the board level fallback (called pinctrl hogs, I think)?
> > This can be part of nand node you added below so that the pinctrl will
> > take effect when nand gets probed instead of all the time.
>
> Yes we should have all the pinctrl entries under the related drivers.
> This makes it easy remux pins during runtime if needed, and also
> allows unloading pinctrl-single.ko for development.
>
Yes, accepted. This has been already fixed in v3 of this patch set.
If all fine, then please pull this for next merge..
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html (already pulled)
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html
with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/