Re: [PATCH 10/15] perf ftrace: Add 'show' sub-command

[Jiri Olsa]

On Tue, May 14, 2013 at 07:13:54PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
> 

SNIP

> +
> +static LIST_HEAD(ftrace_cpu_buffers);
> +
> +static int process_sample_show(struct perf_tool *tool,
> +			       union perf_event * event __maybe_unused,
> +			       struct perf_sample *sample,
> +			       struct perf_evsel *evsel __maybe_unused,
> +			       struct machine *machine __maybe_unused)
> +{
> +	struct perf_ftrace *ftrace;
> +	struct perf_ftrace_report *show;
> +	struct ftrace_report_arg *fra;
> +	struct stat statbuf;
> +	enum kbuffer_long_size long_size;
> +	enum kbuffer_endian endian;
> +	char buf[PATH_MAX];
> +
> +	show = container_of(tool, struct perf_ftrace_report, tool);
> +	ftrace = show->ftrace;

this seems to be exactly same routine as process_sample_report
with exception of above 2 lines.. maybe the rest of it could be
common function?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/