Re: [PATCH 03/15] perf util: Save pid-cmdline mapping into tracing header

[Namhyung Kim]

On Wed, 15 May 2013 23:21:24 +0200, Jiri Olsa wrote:
> On Tue, May 14, 2013 at 07:13:47PM +0900, Namhyung Kim wrote:
>> +void parse_saved_cmdline(struct pevent *pevent,
>> +			 char *file, unsigned int size __maybe_unused)
>
> any reason for the size parameter? I can see some other
> functions already following this prototype, but I dont
> see the reason.. just curious ;)

I don't know, but copied those. ;)  I guess we can get rid of it.
Steve, any comments?

Thanks,
Namhyung

>
> void parse_ftrace_printk(struct pevent *pevent,
>                          char *file, unsigned int size __maybe_unused)
>
> void parse_proc_kallsyms(struct pevent *pevent,
>                          char *file, unsigned int size __maybe_unused)
>
>
> jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/