Re: [PATCH V2 6/8] pktcdvd: Convert pr_notice to pkt_notice

[Andy Shevchenko]

On Sat, Jun 1, 2013 at 7:11 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> Add a new pkt_notice macro to prefix the name to the logging output.

One nitpick below.

> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -71,17 +71,19 @@
>
>  #define DRIVER_NAME    "pktcdvd"
>
> +#define pkt_err(pd, fmt, ...)                                          \
> +       pr_err("%s: " fmt, pd->name, ##__VA_ARGS__)
> +#define pkt_notice(pd, fmt, ...)                                       \
> +       pr_notice("%s: " fmt, pd->name, ##__VA_ARGS__)
> +
>  #define pkt_dbg(level, pd, fmt, ...)                                   \
>  do {                                                                   \
>         if (level == 2 && PACKET_DEBUG >= 2)                            \
> -               pr_notice("%s: %s():" fmt,                              \
> -                         pd->name, __func__, ##__VA_ARGS__);           \
> +               pkt_notice(pd, "%s(): " fmt, __func__, ##__VA_ARGS__);  \
>         else if (level == 1 && PACKET_DEBUG >= 1)                       \
> -               pr_notice("%s: " fmt, pd->name, ##__VA_ARGS__);         \
> +               pkt_notice(pd, fmt, ##__VA_ARGS__);                     \
>  } while (0)
>
> -#define pkt_err(pd, fmt, ...)                                          \
> -       pr_err("%s: " fmt, pd->name, ##__VA_ARGS__)

May be put this in the right place before?

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/