Re: [PATCH V2 6/8] pktcdvd: Convert pr_notice to pkt_notice

[Joe Perches]

On Sun, 2013-06-02 at 15:12 +0300, Andy Shevchenko wrote:
> On Sat, Jun 1, 2013 at 7:11 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > Add a new pkt_notice macro to prefix the name to the logging output.
> 
> One nitpick below.
> 
> > --- a/drivers/block/pktcdvd.c
[]
> > +#define pkt_err(pd, fmt, ...)                                          \
> > +       pr_err("%s: " fmt, pd->name, ##__VA_ARGS__)
> > +#define pkt_notice(pd, fmt, ...)                                       \
> > +       pr_notice("%s: " fmt, pd->name, ##__VA_ARGS__)
> > +
[]
> > -#define pkt_err(pd, fmt, ...)                                          \
> > -       pr_err("%s: " fmt, pd->name, ##__VA_ARGS__)
> 
> May be put this in the right place before?

It all ends up well.  I think it's not worth the bother.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/