Re: [RFC PATCH v0 0/2] dw_dmac: move to own folder and split

[Andy Shevchenko]

On Mon, 2013-06-03 at 10:35 +0530, Viresh Kumar wrote: 
> On 31 May 2013 21:20, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > This is first attempt to do split as suggested by Arnd et al.
> > First patch moves driver to its own folder.
> > Second one does the actual split.
> >
> > During this files are renamed: mostly means that dw_dmac prefix is eliminated.
> > I hope to get it ready to be included in v3.11.

> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Thanks for review.

I still have doubts about few things.

I did renaming twice, first time it's actually moving to folder and
keeping the same file names, and second time when I split driver. Might
be better to do this in first patch? My logic here is to distinguish
just moving, that's why I kept names.

In patch 2/2 I collect platform related code. I see a lot of #ifdefs
related to OF and ACPI. I would like to split it further and create
files like of.c and acpi.c. What do you think?

Last thing, I would like to prepare PCI driver (which is not ready yet
in new shape) and see how it will go with this split.

And I forgot to mention that patch series relies on the patch I sent
before (clean up for devm_ioremap_resources) and Vinod didn't apply yet.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/