Re: [RFC PATCH v0 0/2] dw_dmac: move to own folder and split

[Viresh Kumar]

On 3 June 2013 17:55, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> I still have doubts about few things.
>
> I did renaming twice, first time it's actually moving to folder and
> keeping the same file names, and second time when I split driver. Might
> be better to do this in first patch? My logic here is to distinguish
> just moving, that's why I kept names.

What you did is absolutely correct and renaming makes more
sense in 2/2.

> In patch 2/2 I collect platform related code. I see a lot of #ifdefs
> related to OF and ACPI. I would like to split it further and create
> files like of.c and acpi.c. What do you think?

Naahh.. OF by itself doesn't mean anything here on this driver. It
belongs to all the users that are using DT to enumerate it (Mostly
ARM). And they are going to use platform_driver interface. So,
code is well located currently too..

ACPI, I am not sure.. you need these routines in your pci stuff too?
Keep it this way:
- Keep all the common stuff across pci and platform in core.c
- everything else in pci and platform files.

> And I forgot to mention that patch series relies on the patch I sent
> before (clean up for devm_ioremap_resources) and Vinod didn't apply yet.

I understood it when I tried to apply it at my end :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/