Re: strange crashes in tcp_poll() via epoll_wait

[Eric Wong]

Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Hi Al
> 
> I tried to debug strange crashes in tcp_poll() called from
> sys_epoll_wait() -> sock_poll()
> 
> The symptom is that sock->sk is NULL and we therefore dereference a NULL
> pointer.
> 
> It's really rare crashes but still, it would be nice to understand where
> is the bug. Presumably latest kernels would crash in sock_poll() because
> of the sk_can_busy_loop(sock->sk) call.
> 
> We do test sock->sk being NULL in sock_fasync(), but epoll should be
> safe because of existing synchronization (epmutex) ?

It should be safe because of ep->mtx, actually, as epmutex is not taken
in sys_epoll_wait.

I took a look at this but have not found anything.  I've yet to see this
this on my machines.

When did you start noticing this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/