Re: [PATCH] perf tool: don't print bogus data on -e instructions

[Ingo Molnar]

* Ramkumar Ramachandra <artagnon@xxxxxxxxx> wrote:

> When only the instructions event is requested:
> 
> $ perf stat -e instructions git s
> M  builtin-stat.c
> 
>  Performance counter stats for 'git s':
> 
>        917,453,420 instructions              #    0.00  insns per cycle
> 
>        0.213002926 seconds time elapsed
> 
> The 0.00 insns per cycle comment in the output is totally bogus and
> misleading. It happens because update_shadow_stats() doesn't touch
> runtime_cycles_stats when only the instructions event is requested. So,
> omit printing the bogus data altogether.
> 
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx>

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/