Re: [PATCH -next] misc: fix various misc/mic/host/ build errors
From: Greg Kroah-Hartman
Date: Wed Oct 16 2013 - 15:44:46 EST
On Wed, Oct 16, 2013 at 12:41:08PM -0700, Randy Dunlap wrote:
> On 10/16/13 12:26, Greg Kroah-Hartman wrote:
> > On Mon, Oct 14, 2013 at 12:38:06PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> >>
> >> Fix various build errors (on x86_64) for drivers/misc/mic/host/:
> >>
> >> drivers/misc/mic/host/mic_main.c:378:3: error: too many arguments to function 'sysfs_get_dirent'
> >> drivers/misc/mic/host/mic_intr.h:134:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
> >> drivers/misc/mic/host/mic_intr.h:134:58: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> >> drivers/misc/mic/host/mic_intr.h:135:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
> >> drivers/misc/mic/host/mic_device.h:169:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
> >> drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_read':
> >> drivers/misc/mic/host/mic_device.h:169:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
> >> drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_write':
> >> drivers/misc/mic/host/mic_device.h:183:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]
> >>
> >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> >> Cc: Harshavardhan R Kharche <harshavardhan.r.kharche@xxxxxxxxx>
> >> Cc: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>
> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >> Cc: Nikhil Rao <nikhil.rao@xxxxxxxxx>
> >> Cc: Sudeep Dutt <sudeep.dutt@xxxxxxxxx>
> >
> > This is a -next issue only at this point in time, I thought it was in
> > the -next tree as a "fixup" already?
>
> Are you asking the driver maintainers?
No, the linux-next maintainers.
The driver maintainers have nothing to do with this, it's a sysfs change
in my driver-core tree that causes this issue.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/