Re: [PATCH -next] misc: fix various misc/mic/host/ build errors

[Thierry Reding]

On Wed, Oct 16, 2013 at 12:44:40PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Oct 16, 2013 at 12:41:08PM -0700, Randy Dunlap wrote:
> > On 10/16/13 12:26, Greg Kroah-Hartman wrote:
> > > On Mon, Oct 14, 2013 at 12:38:06PM -0700, Randy Dunlap wrote:
> > >> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > >>
> > >> Fix various build errors (on x86_64) for drivers/misc/mic/host/:
> > >>
> > >>   drivers/misc/mic/host/mic_main.c:378:3: error: too many arguments to function 'sysfs_get_dirent'
> > >>   drivers/misc/mic/host/mic_intr.h:134:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
> > >>   drivers/misc/mic/host/mic_intr.h:134:58: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> > >>   drivers/misc/mic/host/mic_intr.h:135:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
> > >>   drivers/misc/mic/host/mic_device.h:169:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
> > >>   drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_read':
> > >>   drivers/misc/mic/host/mic_device.h:169:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
> > >>   drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_write':
> > >>   drivers/misc/mic/host/mic_device.h:183:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]
> > >>
> > >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > >> Cc: Harshavardhan R Kharche <harshavardhan.r.kharche@xxxxxxxxx>
> > >> Cc: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>
> > >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > >> Cc: Nikhil Rao <nikhil.rao@xxxxxxxxx>
> > >> Cc: Sudeep Dutt <sudeep.dutt@xxxxxxxxx>
> > > 
> > > This is a -next issue only at this point in time, I thought it was in
> > > the -next tree as a "fixup" already?
> > 
> > Are you asking the driver maintainers?
> 
> No, the linux-next maintainers.
> 
> The driver maintainers have nothing to do with this, it's a sysfs change
> in my driver-core tree that causes this issue.

Well, we do carry a patch to fix this, but that generally doesn't get
carried to Linus' tree automatically as far as I know. So I guess it's
fine for now, but when the merge window opens you'll need to make sure
that Linus merges the branches in the correct order so that the build
doesn't break in between.

I think the typical way to solve this kind of build dependencies between
trees is for one tree to provide a stable branch that can be merged into
the other. That ensures that each tree can still be built independently.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature