Re: [PATCH] arm64: add PAGE_ALIGNED_DATA to linker script

[Catalin Marinas]

On Fri, Oct 11, 2013 at 01:18:41PM +0100, Mark Salter wrote:
> On Wed, 2013-10-09 at 11:14 +0100, Will Deacon wrote:
> > > @@ -110,6 +110,7 @@ SECTIONS
> > >                */
> > >               INIT_TASK_DATA(THREAD_SIZE)
> > >               NOSAVE_DATA
> > > +             PAGE_ALIGNED_DATA(PAGE_SIZE)
> > >               CACHELINE_ALIGNED_DATA(64)
> > >               READ_MOSTLY_DATA(64)
> > 
> > Can we just replace this chunk with RW_DATA_SECTION(64, PAGE_SIZE,
> > THREAD_SIZE) instead?
> > 
> 
> I took a look at this. It can be done, but the RW_DATA_SECTION aligns
> data to PAGE_SIZE where the existing alignment is THREAD_SIZE. So using
> RW_DATA_SECTION would waste some space if using 64K pagesize.

I think that's ok, especially since we may get security patches in the
future to create more restrictive page table attributes (well, with the
drawback of more TLB pressure). So I'm for more cleanup in the vmlinux
file by using the generic defines.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/