Re: [PATCH -next] pinctrl: imx1: fix return value check in imx1_pinctrl_core_probe()

[Linus Walleij]

On Thu, Oct 31, 2013 at 8:51 AM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:

> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> In case of error, the function devm_ioremap_nocache() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Patch applied.

I don't know why I miss such things during review all the time :-(

Anyway it is great that you fix it up!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/