Re: [PATCH 2/2] mm: thp: give transparent hugepage code a separatecopy_page

[Dave Hansen]

On 11/06/2013 05:46 AM, Hillf Danton wrote:
> On Tue, Oct 29, 2013 at 6:16 AM, Dave Hansen <dave@xxxxxxxx> wrote:
>> +
>> +void copy_high_order_page(struct page *newpage,
>> +                         struct page *oldpage,
>> +                         int order)
>> +{
>> +       int i;
>> +
>> +       might_sleep();
>> +       for (i = 0; i < (1<<order); i++) {
>> +               cond_resched();
>> +               copy_highpage(newpage + i, oldpage + i);
>> +       }
>> +}
> 
> Can we make no  use of might_sleep here with cond_resched in loop?

I'm not sure what you're saying.

Are you pointing out that cond_resched() actually calls might_sleep() so
the might_sleep() is redundant?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/