Re: [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page

From: Hillf Danton
Date: Wed Nov 06 2013 - 08:46:25 EST


On Tue, Oct 29, 2013 at 6:16 AM, Dave Hansen <dave@xxxxxxxx> wrote:
> +
> +void copy_high_order_page(struct page *newpage,
> + struct page *oldpage,
> + int order)
> +{
> + int i;
> +
> + might_sleep();
> + for (i = 0; i < (1<<order); i++) {
> + cond_resched();
> + copy_highpage(newpage + i, oldpage + i);
> + }
> +}

Can we make no use of might_sleep here with cond_resched in loop?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/