Re: [PATCH 2/5] regulator: s5m8767: Do not use sec_reg* regmaphelpers

[Lee Jones]

On Tue, 17 Dec 2013, Krzysztof Kozlowski wrote:

> Replace calls to sec_reg* helpers with direct usage of regmap API. The
> sec_reg* helpers are error-prone as they mix u8 with unsigned int and
> order of some of parameters (val and mask in sec_reg_update()).
> 
> Also the helpers do not give any way of useful abstraction as they just
> call corresponding regmap function.
> 
> This patch replaces:
>  - sec_reg_read() with regmap_read(),
>  - sec_reg_write() with regmap_write(),
>  - sec_reg_update() with regmap_update_bits().
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> ---
>  drivers/regulator/s5m8767.c |   71 +++++++++++++++++++++++++------------------
>  1 file changed, 41 insertions(+), 30 deletions(-)
> 

Mark,

As this is heavily reliant on the previous patch, feel free to
take it through the Regulator tree.

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/