Re: [PATCH] cpupower: Fix segfault due to incorrect getopt_long arugments

[Josh Boyer]

On Fri, Oct 11, 2013 at 8:45 AM, Josh Boyer <jwboyer@xxxxxxxxxx> wrote:
> If a user calls 'cpupower set --perf-bias 15', the process will end with a
> SIGSEGV in libc because cpupower-set passes a NULL optarg to the atoi call.
> This is because the getopt_long structure currently has all of the options
> as having an optional_argument when they really have a required argument.
> We change the structure to use required_argument to match the short options
> and it resolves the issue.
>
> This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1000439
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>

Ping?  I sent this 2 months ago and never got a reply.  We're still
carrying it in Fedora.

josh

> ---
>  tools/power/cpupower/utils/cpupower-set.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
> index dc4de37..bcf1d2f 100644
> --- a/tools/power/cpupower/utils/cpupower-set.c
> +++ b/tools/power/cpupower/utils/cpupower-set.c
> @@ -18,9 +18,9 @@
>  #include "helpers/bitmask.h"
>
>  static struct option set_opts[] = {
> -       { .name = "perf-bias",  .has_arg = optional_argument,   .flag = NULL,   .val = 'b'},
> -       { .name = "sched-mc",   .has_arg = optional_argument,   .flag = NULL,   .val = 'm'},
> -       { .name = "sched-smt",  .has_arg = optional_argument,   .flag = NULL,   .val = 's'},
> +       { .name = "perf-bias",  .has_arg = required_argument,   .flag = NULL,   .val = 'b'},
> +       { .name = "sched-mc",   .has_arg = required_argument,   .flag = NULL,   .val = 'm'},
> +       { .name = "sched-smt",  .has_arg = required_argument,   .flag = NULL,   .val = 's'},
>         { },
>  };
>
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/