Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver

[Alan Stern]

On Thu, 23 Jan 2014, Valentina Manea wrote:

> 1. The usbip_status file is no longer created for interface 0, but for
> the whole device (such as
> /sys/devices/pci0000:00/0000:00:01.2/usb1/1-1/usbip_status).
> 2. Per interface information, such as interface class or protocol, is
> no longer sent/received. Only device specific information is
> transmitted.
> 3. Since the driver was moved one level below in the USB architecture,
> there is no need to bind/unbind each interface, just the device as a
> whole.

If you don't bind the interfaces, they will naturally bind to their 
normal drivers on the host.  You probably don't want that to happen.  
(Although, at the moment, I don't see how you can prevent it.)

Also, in your patch, stub_probe() calls usb_choose_configuration().  
Shouldn't that be done by the client, since the client now has access 
to the entire device?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/