Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes innuma_clear_kernel_node_hotplug().

[David Rientjes]

On Tue, 28 Jan 2014, Tang Chen wrote:

> On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug()
> was not initialized. So we need to initialize it.
> 
> Signed-off-by: Tang Chen <tangchen@xxxxxxxxxxxxxx>
> Tested-by: Gu Zheng <guz.fnst@xxxxxxxxxxxxxx>

Reported-by: David Rientjes <rientjes@xxxxxxxxxx>

> ---
>  arch/x86/mm/numa.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
> index 81b2750..00c9f09 100644
> --- a/arch/x86/mm/numa.c
> +++ b/arch/x86/mm/numa.c
> @@ -569,6 +569,8 @@ static void __init numa_clear_kernel_node_hotplug(void)
>  	unsigned long start, end;
>  	struct memblock_type *type = &memblock.reserved;
>  
> +	nodes_clear(numa_kernel_nodes)

Just initialize it with NODE_MASK_NONE.

> +
>  	/* Mark all kernel nodes. */
>  	for (i = 0; i < type->cnt; i++)
>  		node_set(type->regions[i].nid, numa_kernel_nodes);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/