Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes innuma_clear_kernel_node_hotplug().

[Ingo Molnar]

* David Rientjes <rientjes@xxxxxxxxxx> wrote:

> On Tue, 28 Jan 2014, Tang Chen wrote:
> 
> > On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug()
> > was not initialized. So we need to initialize it.
> > 
> > Signed-off-by: Tang Chen <tangchen@xxxxxxxxxxxxxx>
> > Tested-by: Gu Zheng <guz.fnst@xxxxxxxxxxxxxx>
> 
> Reported-by: David Rientjes <rientjes@xxxxxxxxxx>

Agreed. Tang Chen, please also spell it out in the changelog:

   David Rientjes reported a boot crash, caused by
   commit XYZ ("foo: bar").

I find it somewhat annoying that you found time to credit a corporate 
collegue with a Tested-by tag, who didn't even reply to the whole 
thread to indicate his testing efforts, but you didn't find the time 
to credit the original reporter of the bug who also reviewed your 
patches ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/