Re: [PATCH] Make math_state_restore() save and restore the interrupt flag

From: Suresh Siddha
Date: Sat Feb 01 2014 - 20:35:57 EST


On Sat, Feb 1, 2014 at 5:26 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> Even "b" does that, no?

oh right. It needs an else. only for non-eager fpu case we should do stts()

void __kernel_fpu_end(void)
{
if (use_eager_fpu()) {
struct task_struct *me = current;

if (tsk_used_math(me) && likely(!restore_fpu_checking(
me)))
return;
} else
stts();
}

thanks,
suresh

> "a" should be fine as long as we don't ever use
> those features in the kernel, even under kernel_fpu_begin/end().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/