Re: [PATCH] Make math_state_restore() save and restore the interrupt flag

[Linus Torvalds]

On Sat, Feb 1, 2014 at 5:35 PM, Suresh Siddha <sbsiddha@xxxxxxxxx> wrote:
> On Sat, Feb 1, 2014 at 5:26 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>> Even "b" does that, no?
>
> oh right. It needs an else. only for non-eager fpu case we should do stts()

It definitely does not want an else, I think.

If tsk_used_math() is false, or if the FPU restore failed, we
*definitely* need that stts(). Otherwise we'd return to user mode with
random contents in the FP state, and let user mode muck around with
it.

No?

                     Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/