Re: [PATCH v1 09/11] x86: perf: intel_pt: Add core dump functionality

From: Andi Kleen
Date: Thu Feb 06 2014 - 15:36:14 EST


> char *buf)
> @@ -114,6 +143,7 @@ static ssize_t pt_cap_store(struct device *cdev,
> return -EINVAL;
>
> pt_cap_set(cap, new);
> + pt_cap_string();

Don't we need some lock here? Otherwise it may leak memory with racing writes
and become inconsistent.

-Andi
--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/