Re: [PATCH v1 09/11] x86: perf: intel_pt: Add core dump functionality

From: Alexander Shishkin
Date: Fri Feb 07 2014 - 04:04:37 EST


Andi Kleen <ak@xxxxxxxxxxxxxxx> writes:

>> char *buf)
>> @@ -114,6 +143,7 @@ static ssize_t pt_cap_store(struct device *cdev,
>> return -EINVAL;
>>
>> pt_cap_set(cap, new);
>> + pt_cap_string();
>
> Don't we need some lock here? Otherwise it may leak memory with racing writes
> and become inconsistent.

Good point.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/