Re: [PATCH 02/15] ASoC: dapm: Add locked version of snd_soc_dapm_xxxx_pin functions

From: Mark Brown
Date: Mon Feb 17 2014 - 19:34:59 EST


On Mon, Feb 17, 2014 at 06:06:03PM +0100, Lars-Peter Clausen wrote:

> Hm, this is a bit confusing. For other functions in ASoC when we
> have a pair of functions with the _locked suffix and without the one
> with _locked takes the lock, the other one doesn't. E.g.
> snd_soc_update_bits_locked. Here we do it the other way around.

Yes, this is definitely confusing. The existing naming might not be the
best but making things inconsistent isn't going to help the situation
either.

Attachment: signature.asc
Description: Digital signature