Re: [PATCH 02/16] kernel/sys: Replace opened code implementation with nice_to_rlimit().

[Dongsheng Yang]

On 03/11/2014 05:26 PM, Peter Zijlstra wrote:
> On Tue, Mar 11, 2014 at 05:20:23PM +0800, Dongsheng Yang wrote:
> > From: Joe Perches <joe@xxxxxxxxxxx>
> >
> > Convert 20 - task_nice(p) to nice_to_rlimit(task_nice(p)).
> >
> > Reduce the indent the switch case labels while there.
> >
> > git diff -w shows 3 lines changed and a /* fall-through */ comment added
> >
> >    $ git diff -w -U0 kernel/sys.c
> >    @@ -253 +253 @@ SYSCALL_DEFINE2(getpriority, int, which, int, who)
> >    -                               niceval = 20 - task_nice(p);
> >    +                       niceval = nice_to_rlimit(task_nice(p));
> >    @@ -264 +264 @@ SYSCALL_DEFINE2(getpriority, int, which, int, who)
> >    -                               niceval = 20 - task_nice(p);
> >    +                       niceval = nice_to_rlimit(task_nice(p));
> >    @@ -280 +280 @@ SYSCALL_DEFINE2(getpriority, int, which, int, who)
> >    -                                       niceval = 20 - task_nice(p);
> >    +                               niceval = nice_to_rlimit(task_nice(p));
> >    @@ -1558 +1558 @@ static void k_getrusage(struct task_struct *p, int who, struct rusage *r)
> >    -
> >    +               /* fall-through */
> I would really like to see the whitespace changes separated. I can push
> a scheduler related change into other subsystems, but massive surgery
> like this should not come through the scheduler tree.

Okey, Peter, I will send a single patch about the whitespace changes and 
update
this patch in this thread soon.

Thanx
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/