Re: [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm

From: Mark Brown
Date: Tue Mar 11 2014 - 06:47:30 EST


On Tue, Mar 11, 2014 at 10:59:12AM +0100, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxxxxxxx>

Applied, thanks, though...

> - ret = clk_prepare_enable(rspi->clk);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "unable to prepare/enable clock\n");
> - goto error1;
> - }
> + pm_runtime_enable(&pdev->dev);

...due to the runtime PM API being configurable you're supposed to start
off with the device runtime enabled (this applies to some of the other
patches too). I'm not sure that's terribly realistic for these drivers
though.

Attachment: signature.asc
Description: Digital signature