Re: [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm

[Geert Uytterhoeven]

Hi Mark,

On Tue, Mar 11, 2014 at 11:47 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Tue, Mar 11, 2014 at 10:59:12AM +0100, Geert Uytterhoeven wrote:
>> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxxxxxxx>
>
> Applied, thanks, though...
>
>> -     ret = clk_prepare_enable(rspi->clk);
>> -     if (ret < 0) {
>> -             dev_err(&pdev->dev, "unable to prepare/enable clock\n");
>> -             goto error1;
>> -     }
>> +     pm_runtime_enable(&pdev->dev);
>
> ...due to the runtime PM API being configurable you're supposed to start
> off with the device runtime enabled (this applies to some of the other
> patches too).  I'm not sure that's terribly realistic for these drivers
> though.

Can you please elaborate what should be fixed?

If I disable CONFIG_PM_RUNTIME, the kernel prints:

    Runtime PM disabled, clock forced on.

and the clock is enabled all the time (verified by looking at the clock
registers)?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/