Re: [RFC v3 3/3] of: Make of_find_node_by_path() handle /aliases

[Rob Herring]

On Sat, Mar 15, 2014 at 7:33 AM, Grant Likely <grant.likely@xxxxxxxxxx> wrote:
> On Fri, 14 Mar 2014 16:39:38 -0500, Rob Herring <robherring2@xxxxxxxxx> wrote:
>> On Fri, Mar 14, 2014 at 12:11 PM, Grant Likely <grant.likely@xxxxxxxxxx> wrote:
>> > Make of_find_node_by_path() handle aliases as prefixes. To make this
>> > work the name search is refactored to search by path component instead
>> > of by full string. This should be a more efficient search, and it makes
>> > it possible to start a search at a subnode of a tree.
>> >
>> > Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
>> > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx>
>> > [grant.likely: Rework to not require allocating at runtime]
>> > Signed-off-by: Grant Likely <grant.likely@xxxxxxxxxx>
>>
>> I should have read the comments before trying to figure out why you
>> had that "pointless" recursion...
>
> Hi Rob,
>
> Thanks for the review. However, I'm a little slow this morning and I
> don't understand what you mean. Did I miss an early comment?

No, it's me that was being slow. At first glance I was thinking the
recursion was pointless until I saw the alias + path case.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/