Re: [PATCH V2] NTFS: Logging clean-up

[Joe Perches]

On Sun, 2014-03-16 at 21:52 +0100, Fabian Frederick wrote:
> -Convert spinlock/stat array to va_format (inspired by Joe Perches help
> on previous logging patches).
> -Convert printk(KERN_ERR to pr_warn in __ntfs_warning.
> -Convert printk(KERN_ERR to pr_err in __ntfs_error.
> -Convert printk(KERN_DEBUG to pr_debug in __ntfs_debug.
[]
> diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
[]
> @@ -3093,7 +3094,7 @@ static int __init init_ntfs_fs(void)
>  	int err = 0;
>  
>  	/* This may be ugly but it results in pretty output so who cares. (-8 */
> -	printk(KERN_INFO "NTFS driver " NTFS_VERSION " [Flags: R/"
> +	pr_info(NTFS_VERSION " [Flags: R/"

Be nice to have this say pr_info("driver " NTFS_VERSION " etc...

Other than that, seems like a nice cleanup, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/