Re: [PATCH 0/6] perf tools: Share map groups within process

From: Namhyung Kim
Date: Tue Mar 18 2014 - 20:46:35 EST


Hi Jiri,

On Tue, Mar 18, 2014 at 2:46 PM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> hi,
> this patchset moves thread's map_groups to be dynamically
> allocated and shared within process threads.
>
> The main benefit would be to be able to look up memory
> map from any thread that belongs to the process.
>
> This implements one of the solution ideas for issue
> described by Don in following thread:
> http://marc.info/?l=linux-kernel&m=139403876017159&w=2
>
> RFC changes:
> - added automated test for thread map groups get/put methods
> - fix reference count for case described by Namhyung
> - rename the mmap-events.c test to mmap-thread-lookup.c
> - added PROT_EXEC to mmap call in tests/mmap-thread-lookup.c
> as it's not implied by default on all archs (Namhyung)
> - lazy mg allocation in thread__find_addr_map (Namhyung)
> - fix compilation failures (Arnaldo)

Looks good to me!

Reviewed-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/