Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation
From: Russell King - ARM Linux
Date: Thu Mar 20 2014 - 11:19:56 EST
On Thu, Mar 20, 2014 at 03:59:35PM +0100, Jean-Francois Moine wrote:
> On Thu, 20 Mar 2014 14:31:10 +0000
> Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:
> > 1. change the DT compatible strings the driver has to accept both
> > nxp,tda19988 and nxp,tda19989, and set the appropriate device
> > in the DT file (tda19988). I'm a bit nervous about using
> > "nxp,tda1998x" in case we're clashing with devices with different
> > characteristics.
> The Cubox is sold with either the TDA19988 or the TDA19989 (I don't
> know about the AMX33XX boards). Then, setting the exact type in the DT
> would ask for 2 differents DTs or for having two tda998x definitions in
> a same DT...
I'm not saying that it has to match the physical device fitted - I'm
merely suggesting not using nxp,tda1998x which could (and as Sebastian
has found, does) conflict with other devices with different properties.
We still auto-detect the exact device type by reading the ID register
because that's the most reliable way to detect exactly what kind of
device is fitted to the board.
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/