Re: [PATCH] printk: Fix discarding of records

[Josh Hunt]

On Sun, Feb 16, 2014 at 8:38 PM, Banerjee, Debabrata
<dbanerje@xxxxxxxxxx> wrote:
> On 2/16/14, 7:41 PM, "Linus Torvalds" <torvalds@xxxxxxxxxxxxxxxxxxxx>
> wrote:
>
>>On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata
>><dbanerje@xxxxxxxxxx> wrote:
>>>
>>> No that can't be right, the prev value after every loop is the
>>>msg->flags
>>> from the *last* line in the list, which has no relation to the *first*,
>>>so
>>> reusing it for the top of the next loop is nonsense.
>>
>>Please, Debabrata, humor me, and just try the patch.
>>
>>And try reading the source code. Because your statement is BS.
> ...
>>No, I haven't tested my patch, and maybe it's broken for some subtle
>>reason I'm missing too.
>
> Yes my explanation was wrong, your patch works for me. I assumed printing
> the prefix was desired, but if not, great.

The resulting patch from this discussion:

commit e4178d809fdaee32a56833fff1f5056c99e90a1a
Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date:   Mon Feb 17 12:24:45 2014 -0800

    printk: fix syslog() overflowing user buffer

has not made it into stable yet. Can we add it to the stable queue?
I'm not sure if it needs more bake time, etc.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/