Re: [PATCH] staging: dgrp: Fixed coding style

From: Dan Carpenter
Date: Wed Apr 16 2014 - 03:44:50 EST



On Tue, Apr 15, 2014 at 05:54:39PM -0700, Thomas Tanaka wrote:
> Fixed line width > 80
>
> Signed-off-by: Thomas Tanaka <thomas.tanaka@xxxxxxxxx>
> ---
> drivers/staging/dgrp/dgrp_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgrp/dgrp_sysfs.c b/drivers/staging/dgrp/dgrp_sysfs.c
> index 2f9345f..93803e0c 100644
> --- a/drivers/staging/dgrp/dgrp_sysfs.c
> +++ b/drivers/staging/dgrp/dgrp_sysfs.c
> @@ -108,8 +108,8 @@ int dgrp_create_class_sysfs_files(void)
> ret = sysfs_create_group(&dgrp_class_global_settings_dev->kobj,
> &dgrp_global_settings_attribute_group);
> if (ret) {
> - pr_alert("%s: failed to create sysfs global settings device attributes.\n",
> - __func__);
> + pr_alert("%s: failed to create sysfs global settings device
> + attributes.\n", __func__);

The original was fine. It doesn't cause a checkpatch.pl warning. The
new one is buggy and won't print the correct text.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/