Re: [PATCH 2/8] blk-mq: bidi support

From: Christoph Hellwig
Date: Wed Apr 16 2014 - 12:44:23 EST


On Wed, Apr 16, 2014 at 10:41:30AM -0600, Jens Axboe wrote:
> > - if (!q->request_fn)
> > + if (!q->request_fn && !q->mq_ops)
> > return 0;
> >
> > bcd = &q->bsg_dev;
>
> This looks misplaced. But I dropped the one I generated last week, I'll
> queue it up separately in the drivers branch.

Could be argued that it should be a separate patch, but the check should
work fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/