Re: [PATCH] pinctrl: as3722: fix handling of GPIO invert bit

[Laxman Dewangan]

Hi Andrew,

On Wednesday 16 April 2014 06:55 AM, Andrew Bresticker wrote:
> diff --git a/drivers/pinctrl/pinctrl-as3722.c b/drivers/pinctrl/pinctrl-as3722.c
> index 92ed4b2..c862f9c0 100644
> --- a/drivers/pinctrl/pinctrl-as3722.c
> +++ b/drivers/pinctrl/pinctrl-as3722.c
> @@ -64,7 +64,6 @@ struct as3722_pin_function {
>   };
>   
>   struct as3722_gpio_pin_control {
> -	bool enable_gpio_invert;
>   	unsigned mode_prop;
>   	int io_function;
>   };

Instead of removing this flag and  calling read of register on every 
gpio set, better if we update this flag on probe once and use this for 
entire life.

So adding the code in probe() as

        for (i = 0; i < ARRAY_SIZE(as3722_pingroups); ++i) {
                int gpio_cntr_reg = AS3722_GPIOn_CONTROL_REG(i);
                u32 val;

                ret = as3722_read(as3722, gpio_cntr_reg, &val);
                if (!ret)
as_pci->gpio_control[i].enable_gpio_invert =
                                        !!(val & AS3722_GPIO_INV);
        }


Thanks,
Laxman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/