Re: [PATCH] ipc,shm: increase default size for shmmax

[Michael Kerrisk]

On Thu, Apr 17, 2014 at 12:46 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, 13 Apr 2014 20:05:34 +0200 Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> wrote:
>
>> Hi Andrew,
>>
>> On 04/02/2014 12:08 AM, Andrew Morton wrote:
>> > Well, I'm assuming 64GB==infinity. It *was* infinity in the RHEL5
>> > timeframe, but infinity has since become larger so pickanumber.
>>
>> I think infinity is the right solution:
>> The only common case where infinity is wrong would be Android - and
>> Android disables sysv shm entirely.
>>
>> There are two patches:
>> http://marc.info/?l=linux-kernel&m=139730332306185&q=raw
>> http://marc.info/?l=linux-kernel&m=139727299800644&q=raw
>>
>> Could you apply one of them?
>> I wrote the first one, thus I'm biased which one is better.
>
> I like your patch because applying it might encourage you to send more
> kernel patches - I miss the old days ;)
>
> But I do worry about disrupting existing systems so I like Davidlohr's
> idea of making the change a no-op for people who are currently
> explicitly setting shmmax and shmall.

Agreed. It's hard to imagine situations where people might care
nowadays, but there's no limits to people's insane inventiveness. Some
people really might want to set an upper limit.

> In an ideal world, system administrators would review this change,

And in the ideal world, patches such as this would CC
linux-api@xxxxxxxxxxxxxxx, as described in
Documentation/SubmitChecklist, so that users who care about getting
advance warning on API changes could be alerted and might even review
and comment...

> would remove their explicit limit-setting and would retest everything
> then roll it out.  But in the real world with Davidlohr's patch, they
> just won't know that we did this and they'll still be manually
> configuring shmmax/shmall ten years from now.  I almost wonder if we
> should drop a printk_once("hey, you don't need to do that any more")
> when shmmax/shmall are altered?

Makes some sense. But then what about the (strange) people who really
do want to set a limit. Do we just say that they have to live with the
message?

Cheers,

Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/