Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

[Jiri Olsa]

On Tue, Mar 25, 2014 at 11:15:29AM +0100, Paolo Bonzini wrote:
> Il 24/03/2014 21:49, Christian Borntraeger ha scritto:
> > event_legacy_tracepoint:
> >+PE_NAME '-' PE_NAME ':' PE_NAME
> >+{
> >+	struct parse_events_evlist *data = _data;
> >+	struct list_head *list;
> >+	char sys_name[strlen($1) + strlen($3) + 2];
> >+	sprintf(&sys_name, "%s-%s", $1, $3);
> >+
> >+	ALLOC_LIST(list);
> >+	ABORT_ON(parse_events_add_tracepoint(list, &data->idx, &sys_name, $5));
> >+	$$ = list;
> >+}
> 
> Why isn't '-' part of PE_NAME?

hi Paolo ;-)

because it screws cache events parsing.. we need some code factoring
in this part

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

it'd be nice to add test to tests/parse-events.c, probably s390 specific,
because the parsing code touches the tracepoint format file

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/