Re: [PATCH RESEND 3/5] ARM: berlin: add the pinctrl dependency for the Marvell Berlin SoCs

[Sebastian Hesselbarth]

On 04/17/2014 03:13 PM, Antoine Ténart wrote:
> On Fri, Apr 11, 2014 at 11:05:41AM +0200, Sebastian Hesselbarth wrote:
> > On 04/10/2014 03:07 PM, Antoine Ténart wrote:
> > > Signed-off-by: Antoine Ténart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> > > ---
> > >   arch/arm/mach-berlin/Kconfig | 2 ++
> > >   1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig
> > > index d3c5f14dc142..291f1cac6c3d 100644
> > > --- a/arch/arm/mach-berlin/Kconfig
> > > +++ b/arch/arm/mach-berlin/Kconfig
> > > @@ -4,6 +4,8 @@ config ARCH_BERLIN
> > >   	select GENERIC_IRQ_CHIP
> > >   	select DW_APB_ICTL
> > >   	select DW_APB_TIMER_OF
> > > +	select PINCTRL
> > > +	select PINCTRL_BERLIN
> >
> > As said in the review of the previous patch, drop PINCTRL here
> > and select it in the PINCTRL_BERLIN Kconfig. Also, you'll need
> > PINCTRL_BERLIN_BG2 and PINCTRL_BERLIN_BG2Q as we don't want to
> > bloat each Berlin kernel with both drivers.
>
> Regarding PINCTRL, I can't drop it, pin-controller drivers depend on it.
> drivers/pinctrl/Kconfig begins with:
> 	if PINCTRL

Ah, ok. Then select PINCTRL here and the corresponding
PINCTRL_BERLIN_foo in the individual SoC Kconfig entries.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/